mitchell/hamlab
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 14 Wiki Activity

storage: re-probe smartctl lazily so an install from the Disks tab works without a restart

Browse Source 
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Mitchell-Johnson
2026-09-17 22:53:32 -07:00
co-authored by Claude Fable 5.1
parent c704e87065
commit 38d4ee09ae
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/storage/storage.go
+9 -2
View File
@@ -220,7 +220,14 @@ func New(sudo bool) *Manager {
return &Manager{sudo: sudo, smartctl: ok, cache: map[string]Smart{}} return &Manager{sudo: sudo, smartctl: ok, cache: map[string]Smart{}}
} }
func (m *Manager) HasSmartctl() bool { return m.smartctl } // HasSmartctl re-probes when it was missing at startup, so an install from the Disks
// tab takes effect without a daemon restart.
func (m *Manager) HasSmartctl() bool {
if !m.smartctl {
_, m.smartctl = lookPath("smartctl")
}
return m.smartctl
}
func (m *Manager) run(ctx context.Context, args ...string) ([]byte, int, error) { func (m *Manager) run(ctx context.Context, args ...string) ([]byte, int, error) {
if p, ok := lookPath(args[0]); ok { if p, ok := lookPath(args[0]); ok {
@@ -273,7 +280,7 @@ func (m *Manager) Smart(ctx context.Context, dev string, force bool) Smart {
s.Error = "unknown device" s.Error = "unknown device"
return s return s
} }
if !m.smartctl { if !m.HasSmartctl() {
return s return s
} }
m.mu.Lock() m.mu.Lock()